On 02/15/10 12:08 PM, Evan Layton wrote: > On 2/15/10 9:16 AM, Evan Layton wrote: >> On 2/15/10 8:52 AM, Dave Miner wrote: >>> On 02/12/10 07:59 PM, Evan Layton wrote: >>>> >>>> Because of the way the live CD install does it's cpio of the live CD >>>> image it turns out that Dermot is indeed correct that this fix is not >>>> sufficient. Because the cpio copies the menu.lst off of the live CD we >>>> end up with the menu.lst from the CD and not the one from the microroot. >>>> Because of this we still need to remove the menu.lst from the installed >>>> BE (for example /a/boot/grub/menu.lst). We then need to copy the >>>> menu.lst file from the microroot into the installed BE. >>>> >>>> I've reverted this so that we are still removing /boot/grub/menu.lst but >>>> then copying the correct version from the microroot into it's place. >>>> >>>> I've updated the webrev with the corrected fix. >>>> >>> >>> I think you should have left the removal of /boot/grub/menu.lst from the >>> cleanup list at 2280. That behavior is wrong, period. >> >> OK, it's easy enough to make that change. I had put this back in so that >> the file gets removed before copying the correct version. However sine >> we're copying the file in anyway it's probably not really necessary to >> remove this. >> >>> >>> 2305: I don't think the comment here is accurate. SUNWgrub can't point >>> to the correct location, because it can't know the name of the pool once >>> we have general support for installing into existing pools, or otherwise >>> co-existing with existing root pools. Perhaps you'd like to change the >>> comment to something more like "until SUNWgrub stops packaging a >>> menu.lst"? >> >> Very good point. I'll update the comment to correct this. >> >> Thanks! >> -evan >> > > The webrev has been updated to reflect these changes. > > http://cr.opensolaris.org/~evanl/14475/ >
Looks OK. Dave
