Hi Glenn, I got a question about the messages that got printed via print >> sys.stderr, ..... Strings that are too long are continued on the next line. Those continuation lines are not indented, which makes it harder to read. Do you know whether it is OK? Have you run pylint on the file to make sure this style is OK?
Everything else look good to me. Thanks, --Karen On 02/17/10 01:10 PM, Glenn Lagasse wrote: > Hi All, > > Another stopper for 2010.03. Could I get a couple of reviewers please? > > Defect: > > http://defect.opensolaris.org/bz/show_bug.cgi?id=13193 > > Webrev: > > http://cr.opensolaris.org/~glagasse/slim_13193/ > > What this does is allow the transfer module to write it's output to the > DC log files (which was lost when the VMC project integrated and moved > the im_pop *step* into a finalizer script). I believe I've duplicated > the pre-VMC behaviour with regards to what is logged to various places. > > I've attached some output from a DC run (up to the im-mod step since > anything else isn't relevant). There's a detailed log and a simple log. > The output on the console looks like: > > Build started Wed Feb 17 11:50:42 2010 > Distribution name: OpenSolaris > Build Area dataset: rpool/dc > Build Area mount point: /rpool/dc > ==== im-pop: Image area creation > Initializing the IPS package image area: /rpool/dc/build_data/pkg_image > Setting preferred publisher: opensolaris.org > Origin repository: http://ipkg.sfbay/dev > Verifying the contents of the IPS repository > Installing the designated packages > Uninstalling the designated packages > Setting post-install preferred publisher: opensolaris.org > Origin repository: http://ipkg.sfbay/dev > Setting post-install alternate publisher: contrib.opensolaris.org > Origin repository: http://pkg.opensolaris.org/contrib > Stopping at im-mod: Image area modifications > Build completed Wed Feb 17 12:17:07 2010 > Build is successful. > > Thanks! > > > > > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss > -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://mail.opensolaris.org/pipermail/caiman-discuss/attachments/20100217/465dfe0e/attachment.html>
