Clay, It looks okay to me.
thanks, -ethan On 02/17/10 13:14, Clay Baenziger wrote: > Hi Jan, > Thank you for bringing up the question about docs. I hadn't > realized that we own the man page. I've corrected it in my new webrev: > http://cr.opensolaris.org/~clayb/14539/webrev1/ > > Thank you, > Clay > > On Wed, 17 Feb 2010, Jan Damborsky wrote: > >> Hi Clay, >> >> the fix looks good. >> >> I have one question, though. >> Grepping for "Sun's DHCP" string in our gate reveals: >> >> $ ggrep -Rl "Sun's DHCP" ./ >> ./man/installadm.1m.txt >> ./cmd/installadm/setup-dhcp.sh >> ./cmd/installadm/docs/scenario.html >> ./cmd/installadm/docs/add.html >> ./cmd/installadm/docs/sparcclient.html >> ./cmd/installadm/docs/installadm.html >> ./cmd/installadm/docs/advancedsetup.html >> ./cmd/installadm/setup-dhcp >> >> Might be documentation handled by this bug >> or do you happen to know if it is planned to be >> addressed separately ? >> >> Thank you, >> Jan >> >> >> >> On 02/17/10 02:05 AM, Clay Baenziger wrote: >>> Hi all, >>> Could I get two sets of eyes for my fix to 14539 "fix ups for >>> messages from installadm create-service"? I've got the following >>> code-review: http://cr.opensolaris.org/~clayb/14539/ >>> >>> Thank you, >>> Clay >>> _______________________________________________ >>> caiman-discuss mailing list >>> caiman-discuss at opensolaris.org >>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >> >> > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
