Hi Evan, * Evan Layton (Evan.Layton at Sun.COM) wrote: > I need to get a code review for the following bug that impacts the text > installer. > > Bug: > http://defect.opensolaris.org/bz/show_bug.cgi?id=14795 > > Webrev: > http://cr.opensolaris.org/~evanl/14795/ > > > Some background: > This bug was caused by the fix for 14475 which added code to copy > the correct version of the grub menu into /boot/grub however in the > current slim_source gate the only thing using this is the live Cd > which is x86 only. However in the text install it also does SPARC > and there needs to be a check for SPARC in this code so that it > doesn't attempt to copy the menu file to /boot since on SPARC this > file doesn't exist (only /<pool>/boot/menu.lst exists on SPARC). > > > Testing done: > This fix was tested to make sure that the correct thing happens with > the menu.lst file for the test installer in bot SPARC and X86 as > well as in the live CD.
Looks fine to me. Cheers, -- Glenn
