Hi Keith, Looks good. A nit - disk_selection.py, line 371 blank line not needed.
Alok On Wed, 24 Feb 2010, Keith Mitchell wrote: > Hi all, > > I'm looking for another text installer code review. This addresses some > issues that were caused by some missed changes when addressing the general > code review comments for the text installer. > > In short, some of the windows weren't updated to the proper positions, and > this caused a scroll bar to overwrite some of the text in some situations. > > bug: > http://defect.opensolaris.org/bz/show_bug.cgi?id=14797 > > webrev: > http://cr.opensolaris.org/~kemitche/14797/ > > These were UI changes, so testing was done at the UI level to ensure that the > following screens looked correct in the given situations: > > Disk Selection: 4 or more disks on the system > Summary: Enough summary information printed to warrant a scrolling text field > > Thanks, > Keith > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >
