Jack,
Please look again at
auto_parse_manifest:
309 ai_free_manifest_value_list(char **value_list)
310 {
311 int len = sizeof (value_list) / sizeof (char *);
312 char **list_end =&value_list[len];
len will always be 1, which could cause an overrun when the list length
is zero (and value_list != NULL for some reason).
nit: you don't have to check free() for NULL (314).
Thanks,
William
>>>
>>> On 02/10/10 03:24 AM, Jack Schwartz wrote:
>>>> Hi everyone.
>>>>
>>>> Here is the code review for AI changes to incorporate Driver Update.
>>>>
>>>> Driver Update will allow the installer to install packages of
>>>> needed drivers in its own boot environment before performing the
>>>> installation, and then install those same packages on the target.
>>>> Packages may be explicitly specified in the manifest. They can
>>>> also be found via search, also initiated via the manifest.
>>>>
>>>> http://cr.opensolaris.org/~schwartz/100209.1/webrev/index.html
>>>>
>>>> This webrev is only of AI changes needed to call into the DDU
>>>> library. The DDU team will be posting a separate webrev with their
>>>> library changes.
>>>>
>>>> Testing is ongoing. Testing done:
>>>> - Validation of correct and incorrect manifest entries.
>>>> - Proper calling of DDU library, for explicit package entries
>>>> - Proper calling of DDU library to complete a search and resulting
>>>> installation.
>>>> - Verification that packages are installed when library is
>>>> correctly called, or else sending feedback to the DDU team about
>>>> found library issues.
>>>> - Verified that ManifestServ and DistroConstructor
>>>>
>>>> Please review and send comments/questions by Tues 2/23 COB.
>>>>
>>>> Thanks to the DDU team for helping me on their end, to get this done.
>>>>
>>>> Thanks,
>>>> Jack
>>>> _______________________________________________
>>>> caiman-discuss mailing list
>>>> caiman-discuss at opensolaris.org
>>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>>
>>
>
