Hi John,
I was wondering why you changed how you wanted to pursue this bug
between comment 8 and comment 9 (providing a function which returns
manifest names and one which returns file names vs. adding a parameter)?
Admittedly, I have lots of functions in the original push of the
AI webserver which have tons of parameters and I don't think it does the
consumer code any favors for readability.
Otherwise, the code looks correct to affect the desired change.
Thank you,
Clay
On Fri, 26 Feb 2010, John Fischer wrote:
> All (especially Clay and Ethan),
>
> Here is another webrev that I need reviewed:
>
> http://cr.opensolaris.org/~johnfisc/12724-manifest-names
>
> This is for:
>
> http://defect.opensolaris.org/bz/show_bug.cgi?id=12724
>
> The AI Database code stores manifest names as filenames (with the
> extension .xml). These change adds an optional parameter
> (return_fnames) to the getManNames function in the AI_database.py
> with the default value of True. Thus the code generates the original
> returned filenames (manifest-name.xml). The installadm list
> subcommand code sets this optional parameter to False and gets the
> .xml extension stripped off (the manifest name instead of the
> filename).
>
> I believe this approach is better then changing the internal database
> storage of the manifests as the rest of the webserver code assumes the
> manifest filename and not the manifest name.
>
> Thanks,
>
> John
> _______________________________________________
> caiman-discuss mailing list
> caiman-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>
