On Mar 3, 2010, at 8:40 AM, Keith Mitchell wrote: > Hi Alok, > > On 03/ 2/10 04:28 PM, Alok Aggarwal wrote: >> Hi Keith, >> >> On Tue, 2 Mar 2010, Keith Mitchell wrote: >> >>> Hi all, >>> >>> I'd like to request a code review for the following text >>> installer bugs: >>> >>> 14968 <http://defect.opensolaris.org/bz/show_bug.cgi?id=14968> >>> Update text install DC manifest and ICT to use hierarchical pkg >>> name for SUNWtext-install >>> 14969 <http://defect.opensolaris.org/bz/show_bug.cgi?id=14969> >>> Text Installer SPARC DC manifest needs pkg_repo_addl_authority entry >>> 14975 <http://defect.opensolaris.org/bz/show_bug.cgi?id=14975> >>> some help screens don't display the last line "navigation." >>> >>> >>> Webrev: >>> http://cr.opensolaris.org/~kemitche/14968/ >> >> Looks fine. I just have a question: >> >> help_screen.py: OFFSET was removed because it was not >> being set to anything other than '0'. And the changes >> on lines 182 - 198 are to account for removing OFFSET. >> The changes on lines 254 - 259 are really the adjustments that >> address the display issues. Correct? > > That's correct. I'll note that both issues have the same root > cause, which happens to be that I missed those changes when > addressing code review comments in regards to simplifying such > things (which involved removing many "OFFSET" variables throughout > different screens; in this specific case, I had previously changed > this OFFSET from 2 to 0, and not made appropriate adjustments).
Okay, thanks for explaining. Alok
