On 03/ 4/10 10:07 AM, Matt Keenan wrote: > Hi, > > Looking for code review and some discussion around fix for : > 9551 - gui install does not allow selection of GMT/UTC timezone > http://defect.opensolaris.org/bz/show_bug.cgi?id=9551 > > Webrev : > http://cr.opensolaris.org/~mattman/bug-9551/ > > Fix is to simply add new default item to list of available timezones in the > combo boxes for GMT/UTC, and set this as the default of no local time zone is > found. > > > Whilst investigating this fix I've discovered two seemingly unused APIS within > liborchestrator, and am wondering what they were initially intended for : > > liborchestrator:timezone.c : > om_set_preinstall_timezone(char *country, char *timezone); > om_get_preinstall_timezone(NULL); > > They simply set/get a global variable to the desired Country Code : > char *pre_inst_timezone = strdup(country); > > I cannot find any reference to pre_inst_timezone or om_get_preinstall() > anywhere > on slim ? > > Does anyone know what these were originally intended for ? > Can they be removed ? >
Appear to be leftovers from the SXDE version of the GUI that never got cleaned up. Take that trash out. Dave
