> On 03/ 4/10 12:43 PM, Alexander Eremin wrote: > >> On 03/ 3/10 09:15 AM, Alexander Eremin wrote: > >>> Hi all, > >>> Please review the short fixes for: > >>> 13276 - live-fs-root needs to be more careful > about > >> what USB device > >>> > >>> Webrev's available at > >> http://cr.opensolaris.org/~alhazred/13276/ > >>> > >> > >> In media-fs-root, wouldn't it make more sense to > just > >> unmount and > >> continue (rather than exiting fatally), assuming > that > >> we will find a USB > >> device with the right version? > >> > >> Dave > >> _______________________________________________ > >> caiman-discuss mailing list > >> caiman-discuss at opensolaris.org > >> > http://mail.opensolaris.org/mailman/listinfo/caiman-di > >> scuss > > > > I've updated the fix to reflect the feedback from > Dave. > > http://cr.opensolaris.org/~alhazred/13276/ > > > > Sorry I didn't spend more time thinking about this > initially, but there > is one other thing about the fix that is somewhat a > problem. > Hard-coding usage of the build number from > /etc/release in the CD volume > ID is OK for development builds, but likely not what > we want for release > builds. The reason is that this will cause the CD to > be displayed on > the desktop as "OpenSolaris_134a" (using the expected > build for 2010.03 > as the example), when we would prefer, from a > marketing/documentation > point of view to have it display the release name and > not a build > number; in other words, either "OpenSolaris 2010.03" > or maybe > "OpenSolaris_2010.03" would be preferred for release > builds. Thoughts > on how to modify to allow that? > > Dave > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-di > scuss Hi Dave, well, I think that once fix applies to USB, we can to not touch the volumeid in boot_archive and use the name from the manifest while creating iso (as we do at present). For this fix it's enough to create a file (.release?) in the root of CD with only build_number and in media-fs-root just compare this file with 'uname -v'. What you think?
Alexander -- This message posted from opensolaris.org
