On 03/12/10 08:26 AM, William Schumann wrote: > http://cr.opensolaris.org/~wmsch/bug-8575/ > http://defect.opensolaris.org/bz/show_bug.cgi?id=8575 >
Based on the fact that, right now, we do not have actual computation of the installed size based on the set of packages in the AI manifest, why is fixing this bug the right thing to do right now? Doesn't the current state of things at least allow a smaller package set than 4 GB to be installed into a sufficient space, which it appears won't be possible with this fix? Dave > At the core, calls om_get_min_size() to compare to the slice size. This > is the absolute minimum, as opposed to the recommended minimum. > If less than the absolute, abort installation. > If less than the recommended, log errors and proceed. > > Sample log message for > minimum, but < recommended: >> <OM_I Mar 12 22:22:33> Checking minimum size for install slice >> <OM_E Mar 12 22:22:33> Install slice 0: >> <OM_E Mar 12 22:22:33> 9.98 GiB ( 20939390 sectors) is less than the >> recommended size >> <OM_E Mar 12 22:22:33> 4.80 GiB ( 10065920 sectors) is the absolute >> minimum size. >> <OM_E Mar 12 22:22:33> 12.35 GiB ( 25899008 sectors) is the >> recommended minimum size. > > Tested slices that were too big and too small. Tested differing slice > numbers. Tested creating non-root slice that did not leave enough room > for the root slice. Tested no partitions and no slices in manifest or on > disk. Tested creating a partition in the manifest and not specifying a > slice. > Regression tested GUI > > Also fixed a inconsequential bug found by lint where there should have > been parentheses to make an assignment take precedence over a logical. > > do 'make lint' > William > > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
