Hi Evan,
with respect to ICT part of bug 15152, now when 6932358 is fixed,
do you think we could we simplify the way how ICT calls installgrub(1M) ?
Now it does:
(void) snprintf(cmd, sizeof (cmd),
"%s/sbin/installgrub %s%s/boot/grub/stage1 %s/boot/grub/stage2 "
"/dev/rdsk/%s", target,
install_partition_is_logical_fdisk ? "-mf ":"", /* MBR */
target, target, device);
Since installgrub makes the right thing for logical volume,
could we make the call simpler by not distinguishing between
primary partition and logical volume in ICT, e.g.
(void) snprintf(cmd, sizeof (cmd),
"%s/sbin/installgrub -f %s/boot/grub/stage1 %s/boot/grub/stage2 "
"/dev/rdsk/%s", target, target, target, device);
Thank you,
Jan
On 03/17/10 01:28 AM, Evan Layton wrote:
> After speaking more with Jan Setje-Eilers more about this it appears
> that with the change he made for bug 6932358 this fix is no longer
> needed at all. I'm therefore no going to push this change and will
> close the bug as tracked in bugster. Sorry for the noise.
>
> -evan
>
> On 3/16/10 1:37 PM, Evan Layton wrote:
>> I need a quick code review for the _really_ simple fix for stopper bug
>> 15152.
>>
>> Bug:
>> http://defect.opensolaris.org/bz/show_bug.cgi?id=15152
>>
>> Webrev:
>> http://cr.opensolaris.org/~evanl/15152/
>>
>> Testing was done using the updated version of installgrub inside an
>> extended partition for installation, beadm activate and pkg
>> image-update. This was also tested in a normal partition and it worked
>> correctly.
>>
>> Thanks!
>> -evan
>> _______________________________________________
>> caiman-discuss mailing list
>> caiman-discuss at opensolaris.org
>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>
> _______________________________________________
> caiman-discuss mailing list
> caiman-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
