On 03/23/10 01:05 PM, Karen Tung wrote: > Hi Shawn, > > Please see my comments inline. > > On 03/23/10 10:17, Shawn Walker wrote: >> On 03/23/10 12:12 PM, sanjay nadkarni wrote: >>> Please review the fix for: >>> >>> 15132 <http://defect.opensolaris.org/bz/show_bug.cgi?id=15132> client >>> side AI installs can benefit from using batch pkg installs. The >>> webrev is available at: >>> http://cr.opensolaris.org/~nadkarni/bugfix/ >>> >>> I will need to 2 reviewers for this fix since it is targeted for release >>> build. >>> >>> >>> The following tests for sparc and x86 have been done: >>> Creating DC images for AI, LiveCD and textinstall. >>> Doing AI installs on a large set of systems that spans memory sizes from >>> 512MB to 12GB and diverse x86 and SPARC hardware. (Thanks to Mary Ding). >>> Installs with manifests of over 260 pkgs to add have been tested and it >>> showed significant performance improvement. A graphs that shows this for >>> x86 has been attached to the bug report. SPARC systems also showed >>> similar improvements and once testing is complete, information graphs >>> for that will also be attached to the bug report. >> >> This isn't easily discernible to me, but other things that can help >> here are: >> >> * using --no-refresh and --no-index with all of the install commands >> >> * using --no-index with all of the install commands > --no-index is done for both install and uninstall commands already. > We currently do not have --no-refresh specified for the install commands.
I couldn't tell, so thanks for that. > Previously, installing packages will not refresh the catalog. It sounds > like it > does now? We only have --no-refresh for our set-publisher calls. Install could have always triggered a catalog refresh in the past. However, it used to be set on a time-to-live delay of 4 hours by default, but now it always does it (intentionally). So adding --no-refresh should shave off about 3-8 seconds per install operation. >> * executing a single 'pkg rebuild-index' after all install and >> uninstall operations have completed > > We don't want to include the indexes on the Live CD because they take up > space. "pkg rebuild-index" is executed by the installer on the installed > system. Oh right, sorry. I was thinking AI-context (post install) here and not Distribution Constructor. Cheers, -- Shawn Walker
