Evan, Looks good.
John On 03/25/10 04:48 PM, Evan Layton wrote: > On 3/25/10 5:25 PM, John Fischer wrote: >> Evan, >> >> Are there other places within be_list.c:be_get_zone_be_list() before the >> returns where zone_be should be reset to B_FALSE? > > CRAP! you're right I missed a couple of places where that should have > been done. I've cleaned this up. > >> >> Should there be a BE_UNMOUNT_FLAG_NULL just like there is a >> BE_MOUNT_FLAG_NULL? This could then be used at line 1511 in be_create.c >> and would make it more readable. > > Not a bad idea, I've added that and updated the webrev for both issues. > > Thanks for looking at this! > -evan > >> >> Otherwise looks good. >> >> Thanks, >> >> John >> >> >> On 03/25/10 12:55 PM, Evan Layton wrote: >>> I need reviewers for the following bugs: >>> 7870 - beadm create fails if a zone has a dataset with a non-legacy >>> mountpoint >>> 9949 - beadm unmount fails when filesystems shared between BEs are >>> also mounted. >>> 12360 - beadm activate hits name collision if renamed BE's original >>> name is reused >>> 14096 - be_destroy_zones does not honor forced unmount >>> 14998 - beadm create should clean up entries in menu.lst if >>> corresponding BE doesn't exist and the entry can't be reused. >>> 15245 - beadm create -p can core dump if there are zones >>> >>> >>> Bugs: >>> http://defect.opensolaris.org/bz/show_bug.cgi?id=7870 >>> http://defect.opensolaris.org/bz/show_bug.cgi?id=9949 >>> http://defect.opensolaris.org/bz/show_bug.cgi?id=12360 >>> http://defect.opensolaris.org/bz/show_bug.cgi?id=14096 >>> http://defect.opensolaris.org/bz/show_bug.cgi?id=14998 >>> http://defect.opensolaris.org/bz/show_bug.cgi?id=15245 >>> >>> Webrev: >>> http://cr.opensolaris.org/~evanl/14096/ >>> >>> This has been tested on x86, sparc testing is in progress and >>> will be completed before the changes are pushed. >>> >>> >>> Thanks! >>> -evan >>> _______________________________________________ >>> caiman-discuss mailing list >>> caiman-discuss at opensolaris.org >>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >
