Thank you Dave, The updated webrev is here: http://cr.opensolaris.org/~joev/bug15163_r3/
comments below. Joe On 03/25/10 03:12 PM, Dave Miner wrote: > On 03/25/10 02:50 PM, Joseph J VLcek wrote: >> Hey Dave, >> >> Thanks again for the review feedback. >> >> The updated webrev can be found here: >> http://cr.opensolaris.org/~joev/bug15163_r2/ >> > > Some minor points: > > In the two manifests, the note about legal prefix syntax would be better > if it just referred to an appropriate pkg man page, probably pkg(5), for > the appropriate rules. reworded. pkg(5) and pkg.depotd(1M) are noted. > > ai_publish_pkg > > 357: s/non/not/ fixed on 357/367 and 363/373 > > 378: I think you mean "user specified file as the repository protocol" fixed > > 409: I note that error_handler & cleanup don't close the repository > transaction for the non-file case. Seems like you should try here. > Fixed as we discussed. > Dave > > Thanks! Joe
