Keith,
Thanks for the review, comments are in line.
On 03/19/10 05:22 PM, Keith Mitchell wrote:
Hi Jean,
I just have a few comments on the v3 of the doc:
3.3 Interface table:
Are all "Transfer" sub-classes required to have an "execute" and
"get_progress_estimate" method? If so, than these should be defined in
the parent class to, even if they are no-ops or stubs. (Minor stubs
would make the parent class useful for test cases when an actual
transfer is not needed, not even a 'dry-run').
Yes they are. I'll add the methods to the Transfer class and the
Interface Table with comments that they are no-ops or stubs.
3.4.2.1.3: Would the default here be "None"? My understanding is that
the log level is set overall by the app on the execution engine (or in
the logging module). If the value here is "None", then the 'overall'
value would be used; if a value is given, then override the default
with whatever is passed in.
Not clear. Still working on some of this with the logging project.
3.4.3.2: Perhaps this is nit-picky, but "create_transfer()" is the
interface that requires transfer type is set in the data cache; once
the CPIO transfer object is created, that data is no longer strictly
required.
Not really that nit-picky. I've taken that requirement out of the
CPIO/IPS/SVR4 subclasses and put it into the create_transfer section.
Jean
- Keith
On 03/16/10 12:52 PM, jeanm wrote:
On 03/16/10 01:35 PM, jeanm wrote:
I've updated the transfer module design doc at:
http://hub.opensolaris.org/bin/preview/Project+caiman/CUE_docs
Since I'll be out next week, I would like to get input by COB of
Friday the 19th.
Jean
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
That should really be:
http://hub.opensolaris.org/bin/view/Project+caiman/CUE_docs
Jean
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
