Hi Karen,
Looks fine to me.
Alok
On Fri, 2 Apr 2010, Karen Tung wrote:
Hi Alok and Keith,
I updated the webrev with your comments and retested the changes.
http://cr.opensolaris.org/~ktung/12839-15387-updated/
Thanks,
--Karen
On 04/ 1/10 04:54 PM, Karen Tung wrote:
On 04/01/10 16:50, Alok Aggarwal wrote:
Hi Karen,
On Thu, 1 Apr 2010, Karen Tung wrote:
Hi,
Please review changes to fix the following bugs:
15387 AI and text installs break because network/iscsi/target/legacy was
removed in 136
12839 DC should add 'opensolaris' alias for localhost, rather than
expecting
it from SUNWcs
webrev:
http://cr.opensolaris.org/~ktung/12839-15387/
Testing done:
- built LiveCD image using a b136 based repo, and made sure that auto
login
to GNOME works, install
works, and installed system works correctly.
- built AI and Text Installer X86 and sparc images using the updated DC
manifests, and verified
those images work.
Just one nit: boot_archive_configure: Why not set SED
to be picked up from /usr/bin/sed like all of the other
utilities?
Looks fine otherwise.
Alok
Hi Alok,
Thanks for reviewing the code.
There's no particular reason to use /bin/sed or /usr/bin/sed.
I will change to /usr/bin/sed so it is consistent with the other stuff.
Thanks,
--Karen
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
