Hi Evan/Ehtan,
Sorry for bothering you again about these two fixes. You both reviewed
these changes few months back.
However, because of some reasons I could not go ahead with the rest of
the process and therefore
these two remained pending so far.
Could you please review the latest webrev and give your comments.
Webrev : http://cr.opensolaris.org/~sb229247/caiman-8006/
Workspace : /net/train.sfbay/builds/sb229247/caiman-8006
Thanks,
-Sriman
On 10/30/09 23:58, Ethan Quach wrote:
sriman narayana bhavanam - Sun Microsystems - Bangalore India wrote:
libbe.h
-------
Per the comment at 67, can you move this to the end of the enum
and make the corresponding change to messages.py
I changed it as per your suggestion. But, I would like to understand the
rationale behind the comment at line 67. Why is it necessary to add
messages
at the end of enum to keep them in sync.
Is it not Ok if we add new messages at same position in both libebe.h
and messages.py?
I am asking this for my own understanding.
In general circumstances that is Ok, but we've had cases where
we've had to backpublish libbe to an older build, and though we never
expect to have to do this, when we do, limiting what we *have* to
backpublish is a plus.
Updated Webrev : http://cr.opensolaris.org/~sb229247/caiman-8006/
Looks okay.
thanks,
-ethan
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
