This new element deserves some scrutiny, since it affects the design and
configuration of the Automated Installer. There needs to be some
explanation of how this works: under what circumstances the disk is
actually labeled, what is the behavior if the manifest is reused, what
if an EFI label exists? Suggest that the design changes be floated in
caiman-discuss by proposing changes (perhaps using an algorithm) and
soliciting input in bugzilla, and afterwards, fix it accordingly.
auto_install.c:
As coded, the Target Instantiation functions should not be called
directly, but through ti_create_target(), and only during the TI
phase. This is presently in perform_slim_install:do_ti()
ai_manifest.rng:
The new element belongs in the ai_target_device section, since it
pertains to a particular disk target. Provide some brief comments in
the schema, since we are moving to improving documentation within the
schema.
To be consistent with other elements in the section, it should be
prefaced with "target_device_". Suggest rather
"target_device_label_disk" so that "label" is an active verb. Should
this be named "...label_if_absent" or something to more closely reflect
what actually happens or the intended usage of this element?
On 04/ 6/10 03:12 PM, Alexander Eremin wrote:
Please review the fixes for:
6260 sparc AI need a way to mechanism to explicitly ask for creating
label on Sparc disk
Bug:
http://defect.opensolaris.org/bz/show_bug.cgi?id=6260
Webrev:
http://cr.opensolaris.org/~alhazred/6260/
Tested on sparc and x86 (not affected) successfully.
Part of sample install_log in attachment.
What is the behavior if the disk is already labeled? If the disk has
existing slices and custom slices are specified in the manifest?
William
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
