On 04/07/10 10:56, [email protected] wrote:
On 04/ 7/10 01:33 PM, Karen Tung wrote:
Hi Sue,
line 265, since the values for user_pass is already
retrieved in line 240. Wouldn't
it be better to check that value?
thanks,
--Karen
On 04/ 7/10 09:17 AM, Sue Sohn wrote:
Could I please get a review for the changes to fix:
15511 - Provide popup on Users screen if username entered, but no
user password
http://defect.opensolaris.org/bz/show_bug.cgi?id=15511
Webrev at:
http://cr.opensolaris.org/~sohn/15511/
Copyright has also been updated to comply with the new format.
Thanks,
Sue
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
Hey Sue,
My only comment is along the same lines as what Karen pointed out.
In that user_pass is checked at line 241 and if not login_name at 251.
Wouldn't it be better to integrate the code you are adding at lines
265-269 with that at line 241 or 251?
Joe
Hi Joe,
We want to do the password checking after all of the other checks are done. In
addition, combining the check at 251 doesn't seem an improvement to me because
the if block wouldn't be related to what the else clause would be doing and
would also then "anchor" that check to that code. Given that, I think I'd prefer
to leave the block at 265 where it is.
Thanks,
Sue
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
