Hi Matt,
I have just a nit. I am thinking if it might be better to check for
if (swap_size < 1)
and
if (dump_size < 1)
That would work for both signed as well as unsigned and
would be more aligned with comment above the checks.
Since it is really nit, I will let you decide if you want to
make this change.
Other than that the change looks good.
Thank you,
Jan
On 04/ 9/10 04:31 PM, Matt Keenan wrote:
Quick code review for two line change for bug :
15568 - Checking unsigned int for value < 0 in liborchestrator
http://defect.opensolaris.org/bz/show_bug.cgi?id=15568
webrev:
http://cr.opensolaris.org/~mattman/bug-15568/
Discovered by "make lint" (thanks William).
Change is pretty simple, change < to == for checking the value of an
unsigned int.
cheers
Matt
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
