On 04/16/10 03:30 PM, Keith Mitchell wrote:
Hi Karen,
Please update the copyrights.
Instead of tracking size_to_recv, could it be simplified to:
while (len(results)< size):
results += self.client_sock.recv(size)
- Keith
Hi Keith,
Thank you for reviewing the changes.
I will update the copyrights.
As for simplifying the code like you suggested, it does not work.
I initially had it coded up like that too, but I found that if
you call client_sock.recv(size) with a size value greater
than what's available to read from the socket, that call will hang until
amount of data equal to size is available. That is why
I am keeping track of exactly how much is left to receive like that.
Thanks,
--Karen
On 04/16/10 03:10 PM, Karen Tung wrote:
Hi,
Please review my changes for the following bug:
15567 Build failed - IndexError: list index out of range
webrev:
http://cr.opensolaris.org/~ktung/15567/
Testing:
- Tried building an image using the manifest attached by the bug
submitter.
Verified that the bug is fixed. I was not able to build an image
successfully using that manifest because it contains a lot of unknown
packages.
- For sanity test, also tried building the Live CD image to make sure
the change does not
affect that.
Thanks,
--Karen
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
