I'm updating line 265 to point to "pkg:/system/install/text-install" and re-testing the Text Install. I will leave the remainder to the bugs that deal with renaming the SUNWslim-utils and SUNWgui-install package (mostly because I don't care to have to re-test the GUI, and it's a superficial change).

Webrev is updated.

As to adding the comment, as I mentioned to Glenn, I don't feel that it's necessary. The im-pop stage will fail (due to the need to explicitly install SUNWcs and SUNWcsd first - and once pkg(5) is smart enough that those don't need to be installed first, dependency chains will ideally pull those in automatically), and the issues surrounding how to inform users about the bare minimum package set and what they can or can't modify are well beyond the scope of this set of bug fixes.

- Keith

On 04/28/10 10:04 AM, Karen Tung wrote:
Hi Keith,

In usr/src/cmd/slim-install/finish/install-finish, packages names are
specified without the pkg:/ prefix.  To make things consistent
everywhere, I think it would be a good idea to add it here too.

    264     if textinstall_exists():
265 pkg_remove_list = ['SUNWslim-utils', 'system/install/text-install']
    266     else:
    267         # GUI installer
    268         pkg_remove_list = ['SUNWslim-utils', 'SUNWgui-install']

I also agree with Glenn's comment about adding a comment
in the manifests to emphasis that
the SUNWcsd and SUNWcs packages are required to be explicitly
specified in the package list.

Thanks,

--Karen

On 04/27/10 04:47 PM, Keith Mitchell wrote:
Hi all,

I'd like to request a review of the following changes to DC and AI default manifests that change the packages listed from the old "SUNW" names to the current hierarchical pkg names:
http://cr.opensolaris.org/~kemitche/pkg_rename

Associated bugs:
https://defect.opensolaris.org/bz/show_bug.cgi?id=15507
https://defect.opensolaris.org/bz/show_bug.cgi?id=13447
https://defect.opensolaris.org/bz/show_bug.cgi?id=13446

Testing done:
I have built DC images of all types (Live, Text, AI - x86 and SPARC) with the given package lists. Additionally, I verified that installs of the x86 images work (including a VMC run using the AI image and updated AI manifest), and Mary verified that the SPARC images install as expected.

Additional notes:
All packages are prefixed with "pkg:/" so as to 'root' them (forcing pkg to install a package with that exact name). This is necessary to avoid name clashes (e.g., attempting to install "network/dns/bind" causes pkg to error out with messages such as:

kemit...@kemobile-work->text_install 0 $ pkg info -r network/dns/bind

pkg: 'network/dns/bind' matches multiple packages

    pkg://opensolaris.org/service/network/dns/bind

    pkg://opensolaris.org/network/dns/bind

Note that I used "pkg:/" with a single slash, and no publisher name. This is so that the pkg name is restricted, but not the publisher.

- Keith
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss


_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to