On 05/03/10 14:43, jean.mccormack wrote:
On 05/ 3/10 03:20 PM, Sue Sohn wrote:
Could I please get a review of the changes to fix:

15840 - Entering a 0 for the month and day cause text installer traceback
http://defect.opensolaris.org/bz/show_bug.cgi?id=15840

Webrev at:
http://cr.opensolaris.org/~sohn/15840/

Thanks,
Sue
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Sue,

I'm curious as to why if the month is 0 you return 31 days and not raise an error? I can see that elsewhere in the code this check is done, just wondering why not here.

Jean

If the user enters a 0 for the month, an error is indeed displayed for that field. However, if the user then moves down to the day field before resolving that error, this code (which calculates the number of days in the month for the purposes of range checking) needs to be able to handle the fact that the month is currently 0.

Sue
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to