Hi Keith.
Thanks for your review.
On 05/ 5/10 08:02 AM, Keith Mitchell wrote:
Hi Jack,
I think if any of the commands in live-var-pkg-move fail, the script
should put the service into maintenance mode.
OK. I will also set up so the final state depends on it, per Dave's
suggestion.
The copyright in SUNWslim-utils/prototype_com should be 2008, 2010.
OK. Thanks. Fixed.
If you haven't already done so, please check with Angela Li so that
the change to the text-mode-menu won't affect the Text Installer test
suites upon pushing.
I'll give her a heads-up.
Everything else in the differential webrev looks good to my eye.
I'll send out an updated review when ready.
Thanks,
Jack
- Keith
On 05/ 4/10 09:45 PM, Jack Schwartz wrote:
Hi everyone.
Here is the final webrev for Driver Update:
http://cr.opensolaris.org/~schwartz/100504/webrev/
Delta since last webrev:
http://cr.opensolaris.org/~schwartz/100504/webrev.3.4.diff/
A delta has been prepared for changes since the last webrev. These
changes include fixes for bugs found during testing, copyright
updates, better management of pkg bookkeeping files and inclusion of
text-mode menu selection.
Note: the delta references some files in slim_source which have been
modified by others since my last webrev, so there are some
high-lighted things which are not related to my putback. These files
are:
ai_manifest.rng: only delta item is copyright change.
auto_install.c: disregard lines 757-758, 794-813,
1397-1419
auto_install.h: my changes are copyright and line 364
auto_parse.c: only delta item is copyright change.
ManifestServ.py: only delta item is copyright change.
prototype_com: my changes are copyright and
live-var-pkg-move files
Note: webrev vs slim_source is clearer for build manifests.
Hopefully this review isn't too difficult when the delta is used and
the above accounted-for.
Please send comments by Thursday COB if possible. I want to be ready
to push by Monday AM, assuming final testing bears out and the DDU
pushes to the Dock.
Thanks for your time!
Jack
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
