Hi all,

In the interest of improving the stability of the slim_source gate, and providing tools for developers to more rapidly verify that code changes don't cause regressions in related components, the testing requirements that must be met prior to be pushing have been updated: pushes to slim_source will now require unit tests to be included.

Previously, bug fixes required the fixer to perform "some form" of testing, at the discretion of the fixer and requiring validation during code review. With this change, the testing requirement is more formal[1]. In general, the testing requirements to push to slim_source have three components. First, existing unit tests must not fail as a result of any changes. Second, new unit tests should be delivered that demonstrate the bug being fixed is indeed fixed - the new tests will ensure no regressions occur down the road. Third, basic sanity checking is still expected (make sure an image still boots, etc.) - however, as the gate gets more and more tests, extensive sanity checking becomes unnecessary.

As a general guideline, we are aiming for 80% unit test coverage. Note that bug fixes to areas of the gate that are intended to be replaced by future project work are excluded from this requirement, as the projects that deliver replacement code will be responsible for supplying the initial set of unit tests to the new code. See the Unit Testing section in the link[1] below for details on which areas will not immediately require tests. (Be aware of whether or not a code change will require unit tests *before* starting, and if it's unclear, send questions to this alias to clarify ahead of time).

Please let me know if you have any questions or concerns about this change.

Thanks,
Keith

[1] See item 4 in the following link, as well as the subsection on Unit Testing (immediately follows item 9):
http://hub.opensolaris.org/bin/view/Project+caiman/Developers
This page was updated to reflect the new requirement.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to