Keith,
You need to update several copyright lines.
From disk_selection:
o might want to add a comment to find_size_data().
o since find_size_data() has already updated self.size_line why call
find_size_data() again at 233?
Not a stinkin clue about the test code. I definitely need that
TOI.
Thanks,
John
On 05/13/10 12:04 PM, Keith Mitchell wrote:
Hi all,
Can I get a code review for the following bug:
http://defect.opensolaris.org/bz/show_bug.cgi?id=14442
Webrev:
http://cr.opensolaris.org/~kemitche/14442_with_tests/
Testing summary:
- Added tests to verify that the disk information is copied only if
there was no previously selected disk, or if the selected disk had
changed
- Added tests to verify that the flag ("do_copy") is set when the
selected disk is changed.
- Refactored DiskScreen.__init__ to pull out code depending on the
image_info file into a separate function. Added tests ensuring that
function works as expected. (When that test is run, there is some
output from the underlying function call due to the missing image_info
file - but the function works regardless).
- Take note of the "MockAll" class I added to the test_disk_select.py
file - it uses some Python tricks and results in an object that can
fulfill a large number of dependencies. Could end up being rather
re-usable in the future.
Beyond the testing, also sanity checked the Text Installer UI to
ensure overall correctness of the solution (this was done previously a
few weeks ago, and re-verified today after merging)
Thanks,
Keith
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
