Hi Sarah -
See below...
Thank you for the review.
ginnie
On 05/17/10 08:20 AM, Sarah Jelinek wrote:
Hi Ginnie,
This looks really good. A few comments/questions...
Section 4:
Distro Constructor is able to set up remote logging service-why is
this an assumption? I can see that the application should be able to
set this up but why DC specifically?
This is in reference to a proposed implementation for enabling logging
for the VMC. That is one of the requirements of DC in order for that to
work. I didn't revisit the VMC phase of implementation on this draft.
I've broken the tasks for implementing logging into three phases. This
is part of the third phase.
As for my thoughts on which option to use for adding handlers:
-I would prefer to have an addHandler method that abstracts out
formatting from the consumer.
Yes...this is why I wanted to delineate the options in this section. My
hope is that it helps determine the pros and cons of each option.
However, I just want to be sure I am reading your proposal correct...
in option 1,the formatting is set by the InstallLogger, so the
consumer doesn't have anything to set with this regard, correct?
I mucked that up a little bit. I copied the list of dictionaries out of
my prototype code, and I had set up a dictionary of defaults, one of
them being a format.
Actually, the list of dictionaries looks like this without the function
call to get the format value (I replaced PARAMS.get('format') with
actual formatting values) :
HANDLER = [{'Class': 'FileHandler', 'level': DEBUG_LOG_LEVEL, 'format':
'%(asctime)s - %(levelname)s -\t%(message)s' , 'file':
'/tmp/install/debug_log', 'mode': 'w'}, {'Class': 'FileHandler',
'level': INFO_LOG_LEVEL, 'format': '%(asctime)s - %(name)s -
%(levelname)s - %(message)s', 'file': '/tmp/install/info_log', 'mode':
'w'}]
You can see that the format key in the dictionary is also defined (I was
accessing a format value from another dictionary that I had set
up...sorry about that. I'll change that in the document). If there
wasn't a format value set, then I could either define a default format
for the InstallLogger that is set for a filehandler, or I could use the
default format supplied by the Python logger, which is message only.
So to answer your question, the consumer has the option of setting a
format value.
In option 3, does the consumer have a choice to either add their own
handlers, or use the ones built in to the InstallLogger, using the
dictionary approach?
No. Option 2 implements the default logging behaviorand has the
consumers define the logging attributes. Option 3 implements Option 2
and is supplemented with code that enhances the Python Logger. There is
no dictionary interface with Option 3
Section 9.2: Which option have you chosen? I assume Option 3 based on
the UML diagrams, but you should likely state the choice in this section.
Yes...I think Option 3 going to be the design choice. I'll add that.
thanks,
sarah
****
On 05/13/10 03:17 PM, Ginnie Wray wrote:
Hi -
As a result of some additional research, I've updated sections of the
design document for the install logger. Sections 1 through 11 of the
document below have been updated. I have not revised any of the material
that pertain to remote logging.
http://hub.opensolaris.org/bin/view/Project+caiman/Logging
The current version is v1.3. I've also uploaded a UML diagram that is
included in the document. It's a little small in the document, so you
can take a look with larger font using the online version. It is the UML
diagram v1.3.
I would like to have feedback by COB on May 24th, but I know we're all
busy, so anything beyond that deadline is appreciated as well.
Thanks,
ginnie
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
