Gatekeeper's nit: Copyright date should be "2008, 2010" based on
be_mount.c's first copyright date in slim_source.
(Note: I've not reviewed the actual code)
- Keith
On 05/17/10 09:35 PM, sriman narayana bhavanam - Sun Microsystems -
Bangalore India wrote:
John,
Thanks for the response. Webrev is now uploaded to cr.opensolaris.org
URL : http://cr.opensolaris.org/~sb229247/caiman-10318/
Now, copyright and double use of fclose are fixed.
Please let me know your comments.
Regards,
-Sriman
On 05/17/10 22:50, John Fischer wrote:
Sriman,
The jurassic.eng webrev won't be visible outside of Oracle. So it
seems odd
to be doing a half open review.
The copyright needs to be updated. Also there is an extra fclose() in
loopback_mount_zonepath() at line 1803. The fclose() is also done
within
the goto done code section.
Thanks,
John
On 05/17/10 06:59 AM, sriman narayana bhavanam - Sun Microsystems -
Bangalore India wrote:
Hi,
Could you please review my changes to fix CR 10318 and let me know
your comments.
Webrev :
http://jurassic.eng/net/v4u-1500a-gmp03.uk/export/home/caiman-10318/webrev/
Bug report : https://defect.opensolaris.org/bz/show_bug.cgi?id=10318
Testing done:
----------------
Created following datasets and set their mountpoint properties as
below:
rpool/zones - /zones
rpool/zones/zone1 - /zones/zone1
rpool/zone2 - /zone2
Now, configured two non-global zones zone1 and zone2 with zone paths
/zones/zone1 and /zone2
respectively.
Created boot environment new_be, and mounted it.
#beadm create new_be
#beadm mount new_be /a
#mount -p | grep /a
j...@v4v-machine-b11-gmp03:/# mount -p|grep /a
rpool/ROOT/new_be - /a zfs - no
rw,devices,setuid,nonbmand,exec,xattr,atime
/zones - /a/zones lofs - no ro,nosub
/zones/zone1 - /a/zones/zone1 lofs - no ro,nosub
rpool/zones/zone1/ROOT/zbe-1 - /a/zones/zone1/root zfs - no
rw,devices,setuid,nonbmand,exec,xattr,atime
/zone2 - /a/zone2 lofs - no ro,nosub
rpool/zone2/ROOT/zbe-1 - /a/zone2/root zfs - no
rw,devices,setuid,nonbmand,exec,xattr,atime
It can be observed that only file systems required for non-global
zone paths are loopback mounted under alternate root.
Regards,
-Sriman
_______________________________________________
caiman-discuss mailing list
caiman-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
caiman-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
caiman-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
