Hi Jack,
On 06/ 2/10 12:56 AM, Jack Schwartz wrote:
Hi Jan.
Hi everyone.
Currently AI doesn't copy the logfile if the install fails because
of the DDU or install errors. How come? I would like to fix
this. Mary also filed bug 16088 against Driver-Update on this very
issue.
But I wonder why AI wasn't copying the logfile on errors even
before Driver-Update came along. All I can come up with is:
- if /a wasn't mounted, the copy could generate additional
errors. (Seems like a small issue to me.)
Th original idea behind this behavior was that if the installation
fails,
then we should take the shortest path to abort in order to leave
the system
as untouched as possible for the inspection.
OK...
Also target BE is left mounted on /a in this case (assuming the
failure happened
after BE was created and mounted).
Sure, and it is important that this functionality remains.
In that case, we wanted to avoid cascade of error messages not related
to the failure itself - they would be confusing and could mask the
real
problem - as an recent example, see
https://defect.opensolaris.org/bz/show_bug.cgi?id=11500#c8
OK. I suspected this, but wanted to make sure there wasn't some
other reason as well...
Does anyone have a good reason why I shouldn't attempt to copy the
logfile to /a whether or not any install errors occurred?
I can see that we could make this step more robust by checking for
presence of /a/var/sadm/system/logs directory first and copy log files
only if it exists.
Yes, I was thinking along these lines as well.
Looking at existing ls_transfer() code [1], in case target directory
does not exist,
ls_transfer() calls mkdirp(3GEN) to create it. We could either go
with such
approach or change the behavior as described above. That would work,
since
/var/sadm/system/logs/ directory is currently being delivered by
pkg://opensolaris.org/service/management/sysidtool package.
What I thought to be best would be to check to see if /a existed and
if it did, then to transfer the log.
I moved the ls_transfer() call to above the test/exit for failure, and
now check for INSTALLED_ROOT_DIR before calling ls_transfer(). See
attached.
These changes seem reasonable.
However, when I tested this I realized that there is an ICT called
earlier which does the transfer as well, so the log is actually
transfered twice! So even when I remove the log file move from
auto_install.c, it is still done and still gives errors when the ICT
does it. I need to investigate where the ICT is coming from to know
whether or not I can remove it as part of my fix. (If it is code that
is common to other installer components, I may be better off leaving
it alone.)
Looking at ict_transfer_logs() ICT task
http://src.opensolaris.org/source/xref/caiman/slim_source/usr/src/lib/libict/ict.c#ict_transfer_logs
in case of AI, it does not call ls_transfer(), but instead transfers
additional log
files to the target:
/var/svc/log/application-auto-installer:default.log
/var/svc/log/application-manifest-locator:default.log
/var/adm/messages
/tmp/ai_combined_manifest.xml
What kind of error you see in case DDU fails ?
Jan
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
