Hi John,
thank you very much for review.
Please see my response in line. Comments which are not referred
have been incorporated.
I have put together separate webrev with addressed
code review comments (Joe's portion is included as well) -
it is available at:
http://cr.opensolaris.org/~dambi/bug-15723-cr/
And the delta webrev is available at
http://cr.opensolaris.org/~dambi/bug-15723-cr-delta/
Thanks again !
Jan
On 06/ 8/10 07:49 PM, John Fischer wrote:
[...]
main()
It would be good if all the successful output from the
subfunction under
root and user configuration was indented under the subfunction
title:
|Configuring root account
| Setting root password
| Configuring <roo> account as type <root_account/type>
| ...
|Configuring user account
| ...
A failure would start at column 0 like the subfunction title.
This
makes it easier to glance at what is being performed for which
account.
I agree - it looks much more better. I have re-formated the messages,
smf log file from tested system is available for taking a look at
http://cr.opensolaris.org/~dambi/bug-15723-logs/system-install-config:default.log
Those messages starting with 'passwd:' are emitted by used CLIs, so we
do not
control them.
sc_conv.ksh
Is it always true that the sc_embedded_manifest is always at the
end of the manifest file? Or can it be embedded anywhere within
the file? If it can be anywhere within the file then the
create_new_manifest function assumes that it is always at the end
which is
a problem.
Thank you for pointing this out, since I have not thought about this
aspect, as so far I have always put SC manifest after AI manifest :-)
I have tried 'installadm add' with SC manifest preceding AI manifest,
but it did not validate - if my understanding of RNG schema is correct
it dictates the strict order - AI manifest preceding SC manifest -
excerpt from cmd/ai-webserver/criteria_schema.rng:
...
<element name="ai_criteria_manifest">
<!-- Allow the following in any order -->
<interleave>
<!--
The manifest may or may not
have criteria in it
-->
<zeroOrMore>
<ref name="nm_auto_install_criteria"/>
</zeroOrMore>
<!--
One need not specify an A/I manifest in all
applications, an SC manifest is required
when an A/I manifest is supplied.
-->
<optional>
<ref name="nm_ai_manifest_src"/>
<ref name="nm_sc_manifest_src"/>
</optional>
</interleave>
</element>
...
Based on this, I believe we are covered.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
