On 06/18/10 06:03 AM, [email protected] wrote:
On 06/17/10 04:19 PM, Dave Miner wrote:
I'd appreciate a review of the fix at
http://cr.opensolaris.org/~dminer/slim_6936371/
6936371 install fails if OBP lists multiple paths for boot device
Testing on the originally broken system is not entirely complete due
to some configuration issues that caused the install to fail later in
the ICT's (this one completed without the error seen in the CR) and it
won't be pushed until that's been verified as fixed. I've already
verified that it doesn't regress on other SPARC systems, at least.
Dave
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
Hey Dave,
One comment.
1917 new_oprom_size, new_dev = struct.unpack('I%ds' % oprommaxparam,
Looks as if new_oprom_size is no longer needed. Please confirm and if it
is not it could be removed.
Can't do that; the format of data requires us to unpack as a tuple, so
there has to be someplace to assign the length field to, even though we
don't use it further.
Dave
Joe
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
