Sarah,
Continuing my piecemeal review. Today, it's 6.3 Target Schema.
I see you got a lot of comments here about partition/vdev/slice stuff so
I've confined it to some other items.
- Is the is_root attribute really right at the target level? It seems
to me like it's a pool attribute. What happens if I have multiple
targets with this set to true?
- Similar to discussion on Software schema, will you be removing the
"unknown" from the disk name attribute?
- Isn't the is_logical attribute of a partition implied by the name (and
therefore redundant)?
- Is it really a good idea to default the size_units to gb? In 10
years, that's going to seem so 00's. What about just dispensing with
the separate units attribute and requiring units suffixed to the size
(i.e. 100gb, 2secs, 2tb)? I feel like that might be more comfortable to
the average admin and hold up better over the long term.
- Should there be a comment about the format options are expected to be?
Several things about swap/dump:
- What scope are swap and dump specified under? I don't see any other
reference to them in the schema, so they seem somewhat disconnected.
Maybe that's OK, but the examples didn't show them so I'm kind of wondering.
- Should we have an "automatic" specification for swap/dump (in other
words, use the algorithm that the interactive installers use), or is its
absence expected to imply automatic behavior in AI? If that's the case,
do we need a "none" to disable their creation?
- The comment about swap and dump should be more specific that merely
specifying size would create them with a specific name on the (first?
per comment above) root pool.
- I assume we can specify multiple swap devices?
- Doesn't seem to be any way to specify swapping on a slice. We do this
in some cases currently, though, and right now the pathological behavior
of ZFS swap when exhausted makes it even preferable.
- Wouldn't it make sense to model iscsi as a target_device type?
Dave
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
