On 07/08/10 07:24, Sue Sohn wrote:
On 07/07/10 22:42, Ethan Quach wrote:
Hi Sue,

Thanks for the reviewing, and the additional comments ...

On 07/01/10 11:10, Sue Sohn wrote:
On 06/24/10 17:12, Ethan Quach wrote:
>
> I have posted an updated revision to the derived manifests design.
>
> http://hub.opensolaris.org/bin/download/Project+caiman/DerivedManifests/DerivedManifestsDesignSpec.pdf
>
>
>
> Deltas from the previous version are interspersed throughout, but
> the relevant areas of change are Section 5.
>
> Also note, I am taking a look a the ManifestParser/Writer design to
> understand how the Manifest Input Module proposed in this design
> would fit in with that, so further changes there may occur.  However,
> majority of the document should be reviewable. In particular, I would > like to get any additional feedback on the AI server changes (Section
> 5.3) sooner than later.
>
>
> Comments by 7/1 appreciated.
>
>
> thanks,
> -ethan
>
> _______________________________________________
> caiman-discuss mailing list
> [email protected]
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss


Hi Ethan,

5.2.3.1
o Says script is copied to /var/sadm/system/logs/derived/manifest_script Does this mean that the actual filename will be "manifest_script" and that you won't be retaining the name of the user's script? If the original filename is retained, then I'd suggest using <manifest_script> in the doc. Ditto for /tmp/derived/manifest_script.

No, I actually meant the former.

Is the name of actual script recorded in the log file?

I'm not sure actually. The name of the file as hosted by the install service is known to the manifest-locator service, and I'm not sure if manifest-locator
logs that name into the overall log file (even for regular manifests today).
I'll will check to see what it does and get back to you on this.

5.3.3
o From the syntax specified for set-criteria, it looks like you can't append the criteria in an XML file to existing criteria. Any reason why not? That seems like something that might be desirable.

It was intentionally left out.  The assumption was that written XML
files wouldn't be desirable to piecewise append to the already set criteria.
Having said that, we can add that functionality later if needed.

I missed this the first time, but I also noticed that the syntax for set-criteria shouldn't have the outermost set of square brackets since, unlike add-manifest, the criteria is required.

Yes, you're right.  I'll remove the square brackets there.

o if you use -a to append criteria and the same/similar criteria already exists for the manifest, what is the result? For example, if current criteria is MEM="2048-unbounded" and then the appended criteria is MEM="1024-4096"?? Or if current criteria is IPV4=”10.0.2.100-10.0.2.199” and appended criteria is IPV4=”10.0.5.100-10.0.5.199”??

An error occurs.  This would generate the same error as if
you specified the conflicting criteria when the manifest was
originally added.

So that would mean that if someone wanted to modify or replace an existing criteria, they'd have to add all of the criteria from scratch again, correct?

Yes.


-ethan


Sue

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to