On 07/13/10 07:04 AM, [email protected] wrote:
Hi all,
Could Joe and John please look this over and anyone else who might
be interested? This is the wad of changes for introducing multihomed
support to AI. Please get me your impressions by Monday 7/19.
There is a known bug right now that create-client for X86 doesn't use the
$serverIP keyword as it should yet, so please be cautious of that in your
review.
The code review is posted at:
http://cr.opensolaris.org/~clayb/webrev.multihomed/
Clay, I've tried to mostly avoid repeating other comments already
provided by others.
Dave
ai_sd.py
401: "tuple"
405: s/record/option/. Also avoid contractions (they're l10n-hostile,
though I note we're not internationalized here...). Better would be
"Unable to resolve BootSrvA option from DHCP server: %s"
installadm-common.sh
41: the use of gnu sed can be trivially replaced with nawk and thus not
introduce additional dependencies, but see next comment.
483-628: The scheme used here is overly complex, as you don't need to
compare addresses to ranges. All that should be needed is to compute
the network address for each SMF exclude_net entry and apply the same
prefix to each interface address to calculate its network address. If
they're equal, then they're the same network; if not, then they're not.
499: "beginning"
518-9: comment doesn't parse
installadm.c
488: please use one of the existing C interfaces to enumerate interfaces
installadm.h
164: How about "The service %s already exists" (and make a similar
change to 166).
server.xml
The reformatting is a major step backwards in readability. Please reverse.
setup-dhcp.sh
79: "preferably"
92-124: This would be a fair bit simpler if the design were for the
macro to be assembled in an array and then converted to a full
definition only in the case of an overwrite or printing it out. Then
you'd be able to just invoke dhtadm without pulling the macro definition
you just assembled back apart.
141: "need"
208: this comment isn't accurate, there's a bunch of macro updates that
can happen rather than an add or printing something out
496: "escaped"
setup-sparc.sh
226: we probably should be delivering /etc/netboot in a package; not
clear to me what file mode it'll end up with and so on.
net-fs-root
42-3: What's the justification for going to these timeout values?
57: BOOTFILE is unused
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
