I meant to send this a while back..realized that it was in my drafts
folder. Sorry for the tardy response.
handlers.c:
nit - 68: replace initiate with instantiate
It is not clear from Python documentation if PyDict_New() hands a
pointer to allocated memory that it manages or C function has handle.
The reason I say this is because 116-119, if an error has occurred
pFileDict is set to NULL My question is what happens to the memory
allocated to this ? Is this a leak ?
-Sanjay
On 07/ 9/10 12:33 PM, Ginnie Wray wrote:
Hi
I want to get my code review started, and I still have a little
cleanup to do.
I'm going to generate my code review in two parts with the
first part the C bridge code. I haven't quite got the test code
for the C cleaned up, so I'll present that with the second part as well.
Pointer to the webrev:
http://cr.opensolaris.org/~ginnie/logging_Cfiles/
I would like to have feedback by July 23rd COB.
Thanks,
ginnie
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
