Thank you, Keith and Dave.

I see, I wrote test/test_i18n.py.
But I found bug in convert_paragraph() as well so please let me revise
the webrev in a couple of days which will covert both addition of the
test script and fix for the bug.

Thanks,
Takeshi

On 2010年07月29日 02:49, Keith Mitchell wrote:
Excellent point. It seems I'm the worst at remembering things like copyright and unit tests.

Takeshi, can you provide some PyUnit tests for the i18n.py functions? They should be straightforward.

- Keith

On 07/28/10 10:30 AM, Dave Miner wrote:
I'm surprised to not see any unit tests for the new module...

Dave

On 07/28/10 11:28 AM, Keith Mitchell wrote:
Hi Takeshi,

The changes looked good to me when I reviewed privately.

Since I'll be handling the push of the bundle, one more set of eyes
would be appreciated.

- Keith

On 07/27/10 06:00 PM, Takeshi Asano wrote:
Hi all,

Could you please review fix for text-install i18n issues:

bug: https://defect.opensolaris.org/bz/show_bug.cgi?id=16655
webrev: http://cr.opensolaris.org/~asano/slim-text-16655/

Thanks,
Takeshi
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to