Hi Dave,
Thank you for your comments! I'll be sending an updated webrev shortly.
                                                        Thank you,
                                                        Clay

On Fri, 13 Aug 2010, Dave Miner wrote:

[snip...]
installadm-common.sh:

One thing I notice on re-review is that installadm-common.sh does a number of temporary file manipulations in /tmp, when they need to be in /var/run since it's a privileged process that's running this. I know these were pre-existing, but I'd prefer to see those corrected now, as it should be trivial to retest.

While these are trivial to change from /tmp to /var/run there were some other issues around this code. I think I've made the world better and tested appropriately.

Thank you, I'll give machines ownership; I'll 'fer sure change to preferred; and try to stop being redundand, duplicative and repetitive. (Is it Friday?)

122: machine's

154: preferred

278: s/preexisting/existing/

Dave




Thank you,
Clay

[1]: Output if one has a misconfigured all_services/network property:
---------------------------------------------------------------------
r...@jumprope:/usr/lib/installadm# svcs -a|grep install/server
disabled 22:52:23 svc:/system/install/server:default
r...@jumprope:/usr/lib/installadm# svcadm enable
svc:/system/install/server:default
r...@jumprope:/usr/lib/installadm# svcs -a|grep install/server
maintenance 22:52:29 svc:/system/install/server:default
r...@jumprope:/usr/lib/installadm# svcs -x
svc:/system/install/server:default
svc:/system/install/server:default (Installadm Utility)
State: maintenance since Wed Aug 11 22:52:29 2010
Reason: Start method exited with $SMF_EXIT_ERR_CONFIG.
See: http://sun.com/msg/SMF-8000-KS
See: installadm(1M)
See: /var/svc/log/system-install-server:default.log
Impact: This service is not running.
r...@jumprope:/usr/lib/installadm# tail
/var/svc/log/system-install-server:default.log
[ Aug 11 22:52:21 Executing stop method
("/lib/svc/method/svc-install-server stop"). ]
Stopping the service install_test_ai_sparc._OSInstall._tcp.local
[ Aug 11 22:52:23 Method "stop" exited with status 0. ]
[ Aug 11 22:52:29 Enabled. ]
[ Aug 11 22:52:29 Executing start method
("/lib/svc/method/svc-install-server start"). ]
The SMF all_services/networks property (192.168.1.1/22) does not match a
network interface on this server.
Automated Installations will not work with the current server network
setup.
Please check server network settings and try again.
Unable to enable install_test_ai_sparc
[ Aug 11 22:52:29 Method "start" exited with status 96. ]



_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to