On 08/13/10 03:11 PM, Ginnie Wray wrote:
Hi Keith -
Thanks for taking a look at this. See inline.
ginnie
On 08/13/10 10:19 AM, Keith Mitchell wrote:
[...]
189: Despite the prior except clause, this 'bare' except clause is
still a bit 'dangerous'. Recommend changing 187-190 to a single
"except Exception:" clause (which would not catch the
KeyboardInterrupt/SysExit, but would grab everything else).
(See:
http://docs.python.org/release/2.6.5/library/exceptions.html#exception-hierarchy)
Just to clarify this, the form I was thinking of was:
try:
msg = self.format(record)
self.send(msg)
except Exception:
self.handleError(record)
255: Seems odd to return anything here.
perhaps. But the C bridge code needs a return value in order to deal
with the failure to report_progress.
I suspected something like that; if that's the case, then you should
return something after line 252 for the success case.
[...]
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
