On 08/23/10 01:43 PM, Sue Sohn wrote:
On 08/23/10 10:08, [email protected] wrote:
On 08/23/10 12:34 PM, Sue Sohn wrote:
Could I please get a review of the changes for:
6979162 Unit test shouldn't assume AI service is running
http://monaco.sfbay.sun.com/detail.jsf?cr=6979162
Webrev:
http://cr.opensolaris.org/~sohn/6979162
Thanks,
Sue
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
Hey Sue,
My only question, as we discussed on the phone, is why not combine
lines 159 with line 160 and lines 162 with line 163?
e.g.:
From:
157 '''Ensure no such service is caught'''
158 self.smf_AIservice = smf.AIservice
159 self.mockAIservice = MockAIservice(keyerror=True)
160 smf.AIservice = self.mockAIservice
161 self.smf_AISCF = smf.AISCF
162 self.mockAISCF = MockAISCF()
163 smf.AISCF = self.mockAISCF
To:
'''Ensure no such service is caught'''
self.smf_AIservice = smf.AIservice
smf.AIservice = MockAIservice(keyerror=True)
self.smf_AISCF = smf.AISCF
smf.AISCF = MockAISCF()
Thanks, Joe
Hi Joe,
I made a few changes, such as moving these lines to setUp, adding a
tearDown and changing keyerror to a class variable, but I did combine
the 3 lines to 2 for both cases as suggested.
Webrev is updated.
Thanks,
Sue
Sue,
Looks OK to me.
Thanks for the explanation too!
Joe
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
