Hi John.

I jumped the gun when I added some checks for NULL in my code in response to your code review. Some are correct, but some are not, and I have removed the incorrect ones. This came out in my testing.

If you look at the delta webrev for my reply to you,
http://cr.opensolaris.org/~schwartz/100820.1/webrev.1.2.diff/usr/src/cmd/auto-install/auto_ddu_lib.c.frames.html

Specifically, I have removed:
lines 1111 - 1115
lines 1263 - 1268
lines 1302 - 1307

The reason is that it is possible for ai_get_manifest_values() to legitimately return NULL when there are no matches in the manifest for the path it's trying to get values for. If that NULL value is passed to ai_uniq_manifest_values(), then the latter function will also return NULL legitimately.

    Thanks,
    Jack
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to