Darren, I will review it and send you my comments by Friday.
- Dermot On 09/07/10 15:05, Darren Kenny wrote:
Anyone able to provide some review of this code? Thanks, Darren. On 08/30/10 05:23 PM, Darren Kenny wrote:Hi, After the last code review, several things changed, which were: - Relocation of package from osol_install.data_object_cache to solaris_install.data_object - Renaming of python files as: data_object_cache/data_object.py -> data_object/__init__.py data_object_cache/data_object_cache.py -> data_object/cache.py data_object_cache.data_object_dict.py -> data_object/data_dict.py - Restructuring of objects to correct for better OOD to have the DataObjectBase class without deletion and insertion methods, which is a base class for DataObject, DataObjectCache and DataObjectDict. DataObject adds these methods, and is still the preferred object for people to sub-class. (See attached image for UML diagram - also in design document). - Addition of the 'paths' feature, which added: - object_path - read-only property - find_path(path) - DataObjectBase method. - Addition of pydoc comments to all tests. I've updated the latest webrev at: http://cr.opensolaris.org/~dkenny/install_doc/ Unfortunately producing a diff between webrevs isn't all that useful due to the above changes. I would appreciate if any feedback could be provided by the end of the week. Many Thanks, Darren. _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss_______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
