On 09/ 9/10 06:40 AM, Matt Keenan wrote:
Looking for a 2nd round code review for this bug :
Bug 14004 : libtd should discover zpools on entire partitions
https://defect.opensolaris.org/bz/show_bug.cgi?id=14004
Webrev :
http://cr.opensolaris.org/~mattman/bug-14004
Sorry for the extreme delay in reviewing the updated version.
td_zpool.c:
436: s/*pool/**zi_list/
447: indent seems off here, should be 4?
552,580,613,645: how would zt possibly be NULL if we got past the check
at 545?
556: seems like targetcnt should just be uint32_t to begin with.
562,594,626: no check for calloc failure...
866: not sure I get why you do a replace here rather than checking this
at 803?
Dave
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
