On 10/ 1/10 04:33 AM, Dermot McCluskey wrote:
Alok,
On 10/01/10 01:33, Evan Layton wrote:
On 9/30/10 11:45 AM, Alok Aggarwal wrote:
On Thu, 30 Sep 2010, Keith Mitchell wrote:
I chose "li" simply for example purposes (it's the HTML tag for a
list item).
I think it'd make sense to have the tag imply 'list' somehow -
value might be
confusing in that someone might try to use it for a checkpoint
argument that
expects a single item:
<arg name="foo">
<value>bar</value>
</arg>
<!-- results in the checkpoint failing since it's expecting a
string, not a
list -->
So a tag such as "list_item", or "li" or "list" or something of the
sort might
be better. Alternatively, we could have separate <arg> and
<arglist> tags.
<arg> would not have any subelements, and <arglist> would allow
subelements
(<value> or <item>). That would probably be easier to define in the
schema, as
well.
<arg name="foo">bar</arg>
<arglist name="foo_list">
<item>bar1</item>
<item>bar2</item>
</arglist>
I actually like the <arglist> specification better. That
way, <arg> is always a single value and in the cases a list
is expected <arglist> is used. And, it is infact clearer to
define in the schema as well.
I'm going to go with that unless anyone objects.
No objection, but for clarity can you spell out exactly what changes
you are proposing to the schema. It appears to me you are suggesting
something like this:
Current Schema (execution.dtd):
<!ELEMENT kwargs (arg+)>
<!ELEMENT arg (#PCDATA)>
<!ATTLIST arg name CDATA #REQUIRED>
Proposed Schema:
<!ELEMENT kwargs ((arg | arglist)+)>
<!ELEMENT arg (#PCDATA)>
<!ATTLIST arg name CDATA #REQUIRED>
<!ELEMENT arglist (argitem+)>
<!ATTLIST arglist name CDATA #REQUIRED>
<!ELEMENT argitem (#PCDATA)>
- this implies that <arg> and <arglist> are not mutually exclusive and
that you
can have either or both, multiple times (but must have at least one).
Is that correct? eg:
<kwargs>
<arg name="foo">bar</arg>
<arglist name="list">
<argitem>bar1</argitem>
<argitem>bar2</argitem>
</arglist>
<arglist name="foo_list2">
<argitem>bar3</argitem>
<argitem>bar4</argitem>
</arglist>
<arg name="foo2">bar2</arg>
</kwargs>
So that means it would look like this:
<kwargs>
<arg name=uncompressed_files>???</arg>
<arglist name=???> (why do we need a name here?)
<argitem>"/filename"</argitem>
</arglist>
</kwargs>
I assume that the arg name is the name of the method argument.
Something like execute(uncompressed_file=whatever)?
What is arglist name? Why do we need this at all? I believe
the reason for arglist was so the user knew it was a list not a string.
Is that correct?
If so, then where do they specify a string value? Is that the ??? in the
arg line?
Can we leave this blank if we don't need it?
How about something easier like this:
For a string arg:
<arg name="name">value</arg>
For a list:
<arglist name="name">
<argitem>"filename"</argitem>
</arglist>
In which case you only have one, not both.
Is this sortof what Dermot was saying?
Which means for uncompressed files we would actually have:
<kwargs>
<arglist name="uncompressed_files">
<argitem>"/usr/whatever"</argitem>
</arglist>
</kwargs>
Jean
- seeing as how we already have "args", "arg" and "kwargs", and have
generally agreed on "arglist", I suggest "argitem" for the other new
tag.
(there is already a sub-element called "<name>" under
<software_data>, so
we should not have another similarly-named element)
- the other possible sub-element of checkpoint, "args" (with an "s")
is unchanged
by all this, correct?
Dermot
I like this approach as well but I'd prefer the use of <name/>
instead of <item/> or even <file/> so that it's clear that this is a
list of files that will not be compressed.
(just my $0.02) :)
-evan
Alok
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
