Hi Jan,

It'd be better to check status and len() of the output before splitting the output - if the command errors out and returns an empty string for status, the "co[0].split()[1]" command will fail.

Otherwise, looks good.

- Keith

On 10/13/10 08:55 AM, Jan Damborsky wrote:
Hi,

could I please get a code review for fix for following bug:

6991546 reset_image_uuid() assumes a publisher name of "opensolaris.org"

webrev is available at:
http://cr.opensolaris.org/~dambi/bug-6991546

Thank you,
Jan

tests accomplished:
* GUI installer (based on build 149) run with modified ict.py
* Successful installation of build 149 accomplished.
Detailed install_log is available for taking a look:
http://cr.opensolaris.org/~dambi/bug-6991546/install_log.6991546

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to