Hi Dermot,
On Wed, 13 Oct 2010, Dermot McCluskey wrote:
http://cr.opensolaris.org/~dermot/webrev_mp_mw_04/
Looks good, just a few comments below.
General: I thought that the DTDs would be located under
install_manifest in the source and installed in
/usr/share/install. Is that not correct?
The DTDs (and XML and XSLT) files here are all purely used as
test input files and are not installed under proto or delivered in any
package. They are separate from the "real" files found in other dirs.
Also, see comment below.
In addition to the DTDs being test input files, I think
this project should deliver DTDs into the source tree.
We discussed this a little while back:
http://opensolaris.org/jive/thread.jspa?threadID=133735&tstart=75
We've discussed this before: this awkwardness is caused by how the lxml
APIs operate. I'm open to changing this to make it more consistent, but I
think we need to wait a little to see how XInclude is going to be used in
the install apps first so we can decide what works best.
Sounds good.
parser.py: lines 145-148. Since this is the entry point when
invoked from the engine, shouldn't simply using self.logger
work? FWIW, the DC checkpoints used to do something like what
you have here but we changed it to simply use self.logger and
that works just as well.
When I try that and re-run all my unit tests, only the output from one of the
24 tests is in the log - all the other logging output is missing. Any idea
what's going on here?
I've also noticed that even without making this change, some (but not all)
of the output from my full set of unit tests is missing from the log. It
seems
that tests that use the InstallEngine are not logging, *if* those tests are
run
after some other tests that log output.
Do you have any examples where you have run more than one unit test
file, with more than one test per file, where all the tests log something?
It would be very helpful to have a template of how to initialize and reset
logging, in Engine checkpoints, non-Engine code, and unit tests. Do you
know if such examples exist?
I don't know the answer here but I think Ginnie/Karen are
tracking down for you.
parser.py: line 235: What happens if the DOCINFO specifies an
Internet URL that can be traversed only using a proxy - is there
a way to support validation through a proxy? I'm just asking I
don't have a concrete use case for this ..
By default, lxml will not fetch any entities (files, DTDs, XIncluded
files, etc) that required network access. This was discussed during my
design review and it was agreed to not override this, for security reasons.
Not talking about overriding here. If the specified DTD is
an internet URL and validation is requested, I'm assuming
the validation does occur against the DTD on the internet.
Is that correct?
If so, is there a way to traverse through http proxies?
system-library-install.mf: I think you need to sync with slim_source
I know I'll need to break out my changes from the other CUD changes
to this file before I push, but I've just included the latest version from
the
cud project gate here to show which pkgs the MP/MW files would be going into.
Sounds good. Speaking a little selfishly here, please just
make sure that the DTDs do actually get delivered as part of
this package :)
Alok
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
