On 10/18/10 01:47 PM, Keith Mitchell wrote:


publish_manifest.py:

64: Nit: "append" action should not specify a default of [] (same reason you don't use mutable objects as default kwargs)

Addendum - ignore that. Since a fresh OptionParser object is created each time, it doesn't run into that issue unless parser.parse_args() is run repeatedly (which it's not, and shouldn't be); and the default going from [] to None is likely to cause more trouble than is worth here.

- Keith
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to