HI Keith.
Thanks for reviewing.
On 10/19/10 15:33, Keith Mitchell wrote:
errsvc.c:
Setting argv should be done in the block on lines 204-206 to be
consistent with other changes.
Oops, yes. Thanks. Fixed.
Webrev respun.
Thanks,
Jack
Otherwise, looks good to me.
- Keith
On 10/19/10 11:06 AM, Jack Schwartz wrote:
Hi everyone.
Yesterday I pushed changes for to initialize Python's sys.argv array
in AI so Driver Updates will work there. They want the whole fix to
go into 151, so here's the rest, filed as bug ID 6992897. This fix
infuses the remaining files in slim_source which call
Py_Iniitialize() to also call PySys_SetArgv().
Webrev: http://cr.opensolaris.org/~schwartz/101019.1/webrev/
Bug report: http://monaco.sfbay.sun.com/detail.jsf?cr=6992897
Please send code review comments by tomorrow lunchtime. I want to
push changes by tomorrow COB.
Testing is in progress...
X Builds of AI, Text, Live on X86
X Builds of AI, Text on SPARC
X Install of Text on X86
X Install of AI on X86
X Install of slim on X86
Install of Text on SPARC
Install of AI on SPARC
test suite for errsvc
test suite for libtransfer
test suite for libti
Note that I also filed bug
6992895 Change all PySys_SetArgv() calls to PySys_SetArgvEx()
in slim_source when Python 2.7+ is utilized
to document that we should change to PySys_SetArgvEx() of Python 2.7
when we switch to the next Python version.
Thanks,
Jack
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
