On 10/27/10 09:06, Keith Mitchell wrote:
On 10/26/10 03:40 PM, Sue Sohn wrote:
925-941 what should the behavior be if start_from and pause_before are
the same checkpoint? Or if pause_before is a checkpoint earlier than
start_from?
If start_from and pause_before are the same, no checkpoints will be
executed.
If pause_before is earlier than start_from, a UsageError with a
not-so-helpful message will be raised (from line 949 - what will
happen is the code searches for pause_before only *after* it finds
start_from, so if pause_before comes before start_from, it won't find
pause_before, which will drop to line 949).
The check at line 931 should probably be updated to give a more useful
message for this case by changing to something like:
if cp.name == pause_before:
if found_start:
break
else:
raise UsageError(<message about the arguments being out of
order>)
Note that the test_get_cp_list_pause_before_resume test on line 423 of
test_engine.py checks for this scenario.
Thanks for the suggestion Keith. I will add this check and error to
provide a better error message
for this invalid user input combination.
--Karen
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
