On 10/28/10 12:31 PM, Karen Tung wrote:
On 10/28/10 12:07, Sue Sohn wrote:
On 10/28/10 10:49 AM, Karen Tung wrote:
Hi,
Here's the final webrev for the changes the install engine project plans to
integrate.
It includes all the changes Drew made for the TI related files.
Please take a look if you are interested.
http://cr.opensolaris.org/~ktung/engine_Oct28_update/
I plan to do the push at 3pm pacific time today 10/28/2010. So, if you have
comments about the code, please let me know ASAP so I can address them,
and re-schedule the push as appropriate.
Thanks,
--Karen
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
Hi Karen,
Almost there. :)
install_engine/__init__.py
535 Not sure what this means?
warnings.warn("No checkpoint is executed based.")
886 Didn't notice this before, but this method could use
an "Output" section in the docstring
Thanks,
Sue
Hi Sue,
Thanks for looking over the webrev again.
I fixed the 2 comments above. In addition, as discussed
in the hallway, ti.py and ti.pyc are missing from system-library-install.mf,
I added those 2 files.
Webrev is updated in place.
Thanks,
--Karen
Thanks, Karen. Looks good now.
Sue
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
